[improve][admin] getMessageById gets message by batch index#21813
Closed
nodece wants to merge 1 commit intoapache:masterfrom
Closed
[improve][admin] getMessageById gets message by batch index#21813nodece wants to merge 1 commit intoapache:masterfrom
nodece wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Member
Author
|
Related PR: #19827 |
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
Member
|
Seems we need a PIP?
|
Contributor
|
@dao-jun Yeah I agree. And I left a comment my comment in the discussion: https://lists.apache.org/thread/olftk1n8ty05xwq59s1z75d72xjpj7no |
Member
Author
|
Hi @dao-jun and @BewareMyPower, thank you for your feedback, I want to add |
Contributor
LGTM |
Member
Author
|
Closed by #21918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When the message is a batch message, the
org.apache.pulsar.client.admin.Topics#getMessageByIdAsync(java.lang.String, long, long)only returns the first message from the batch message, this affects our troubleshooting.Modifications
org.apache.pulsar.client.admin.Topics#getMessageByIdAsync(java.lang.String, long, long, int)instead oforg.apache.pulsar.client.admin.Topics#getMessageByIdAsync(java.lang.String, long, long).org.apache.pulsar.client.admin.Topics#getMessageById(java.lang.String, long, long, int)instead oforg.apache.pulsar.client.admin.Topics#getMessageById(java.lang.String, long, long).org.apache.pulsar.admin.cli.CmdPersistentTopics.GetMessageById#runto print all message.org.apache.pulsar.admin.cli.CmdTopics.GetMessageById#runto print all message.Verifying this change
Test added.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: